Re: [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support

[Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>]

Hi Sergei,

Thank you for the review.
Lemme fix it in v5 patchset.

Regards,
Vladimir

On 02.09.2016 15:38, Sergei Shtylyov wrote:
> Hello.
>
> On 9/2/2016 3:05 PM, Vladimir Barinov wrote:
>
> > This supports SSI sound for H3ULCB board.
> > SSI DMA mode used. CS2000 used as AUDIO_CLK_B.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
> > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > ---
> > Changes in version 3:
> > - initially added
> > Changes in version 4:
> > - added comment for audio_clkout
> >
> >  arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 115 
> > +++++++++++++++++++++++++
> >  1 file changed, 115 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts 
> > b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> > index bbd7928..a254231 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> > @@ -45,6 +45,12 @@
> >          };
> >      };
> >
> > +    x12_clk: x12_clk {
>
>    If the crystal name is X12, name the node "x12" too, this way the 
> output clock will be named just "x12".
>
> > +        compatible = "fixed-clock";
> > +        #clock-cells = <0>;
> > +        clock-frequency = <24576000>;
> > +    };
> > +
> >      vcc_sdhi0: regulator-vcc-sdhi0 {
> >          compatible = "regulator-fixed";
> [...]
> > @@ -136,6 +176,73 @@
> [...]
> > +
> > +    cs2000: clk_multiplier@4f {
>
>    Don't use underscores in the node names, use hyphens instead.
>
> > +        #clock-cells = <0>;
> > +        compatible = "cirrus,cs2000-cp";
> > +        reg = <0x4f>;
> > +        clocks = <&audio_clkout>, <&x12_clk>;
> > +        clock-names = "clk_in", "ref_clk";
> > +
> > +        assigned-clocks = <&cs2000>;
> > +        assigned-clock-rates = <24576000>; /* 1/1 divide */
> > +    };
> > +};
> [...]
>
> MBR, Sergei