On Fri, Sep 02, 2016 at 01:19:49AM +0000, Kuninori Morimoto wrote:
>
> Hi Vladimir
>
> > This supports SSI sound for H3ULCB board.
> > SSI DMA mode used. CS2000 used as AUDIO_CLK_B.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
> > ---
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> > + audio_clkout: audio_clkout {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <11289600>;
> > + };
>
> I think having commont for AUDIO_CLKOUT is better for user, like Salvator-X.
> This "audio_clkout" is dummy. Actually, we don't need this dummy clock,
> and we should use "<&rcar_sound 0>" as AUDIO_CLKOUT,
> like AUDIO_CLKOUT3 as "<&rcar_sound 3>" which is used on ak4613.
> But Salvator-X and this ULCB board has very complex connection,
> especially around CS2000.
> This means cs2000 requests rcar_sound, and rcar_sound requests cs2000.
> This audio_clkout exist to avoid probe dead-lock.
> This is the reason why audio_clkout and rcar_sound::clock-frequency
> has same value.
Vladimir,
please address the above and include it when you repost the patches
that I haven't queued up.
