Re: [PATCH v2 2/4] arm64: dts: renesas: r8a7795: Add VSP instances

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

(CC'ing Morimoto-san)

On Monday 29 Aug 2016 18:12:07 Geert Uytterhoeven wrote:
> On Tue, Aug 9, 2016 at 2:29 PM, Laurent Pinchart wrote:
> > The r8a7795 has 9 VSP instances.
> 
> 7?
> 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > ---
> > 
> >  arch/arm64/boot/dts/renesas/r8a7795.dtsi | 90 +++++++++++++++++++++++++++
> >  1 file changed, 90 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index
> > f8b1c421e845..d9c6653471f4 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -1323,6 +1363,16 @@
> >                         power-domains = <&sysc R8A7795_PD_A3VP>;
> >                 };
> > 
> > +               vspi2: vsp@fe9c0000 {
> > +                       compatible = "renesas,vsp2";
> > +                       reg = <0 0xfe9c0000 0 0x8000>;
> > +                       interrupts = <GIC_SPI 446 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD 629>;
> > +                       power-domains = <&sysc R8A7795_PD_A3VP>;
> > +
> > +                       renesas,fcp = <&fcpvi2>;
> > +               };
> > +
> >                 fcpvi2: fcp@fe9cf000 {
> >                         compatible = "renesas,r8a7795-fcpv",
> >                         "renesas,fcpv";
> >                         reg = <0 0xfe9cf000 0 0x200>;
> > @@ -1351,6 +1431,16 @@
> >                         power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> >                 };
> > 
> > +               vspd3: vsp@fea38000 {
> > +                       compatible = "renesas,vsp2";
> > +                       reg = <0 0xfea38000 0 0x4000>;
> > +                       interrupts = <GIC_SPI 469 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD 620>;
> > +                       power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> > +
> > +                       renesas,fcp = <&fcpvd3>;
> > +               };
> > +
> 
> Looks like vspi2 and vspd3 are no more...

What the f... The latest errata agrees with you, and if the documentation is 
indeed correct, that's a completely brain-dead design change. I have no idea 
how the DU is supposed to be used if both DU0 and DU3 are connected to the 
same VSP (VSPD0), as mentioned in the latest H3 errata. Furthermore, the 
change doesn't seem to be applicable to ES1.0, as I've successfully tested the 
VGA output on my Salvator-X board, using VSPD3.

Morimoto-san, could you please try to get more information about this ?

-- 
Regards,

Laurent Pinchart




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux