On Fri, Aug 12, 2016 at 12:20:51PM +0300, Laurent Pinchart wrote:
> Hi Geert,
>
> On Thursday 11 Aug 2016 18:37:03 Laurent Pinchart wrote:
> > On Thursday 11 Aug 2016 11:17:17 Geert Uytterhoeven wrote:
> > > On Tue, Aug 9, 2016 at 2:29 PM, Laurent Pinchart wrote:
> > > > Only the VGA output is supported for now.
> > > >
> > > > Signed-off-by: Laurent Pinchart
> > > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > >
> > > One question below, though...
> > >
> > > > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > > > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > > > @@ -135,6 +135,50 @@
> > > >
> > > > +&du {
> > > > + status = "okay";
> > >
> > > Don't you need pinctrl properties? Or are you relying on initial settings?
> > >
> > > GPSR initial settings for DU depend on MD[4:1] i.e. SW10[5:8].
> > > The defaults on my board are not 0000, so all DU pins are GPIOs?
> > > IPSR initial settings don't seem to be documented.
> >
> > pinctrl configuration is needed, but isn't available yet in the sh-pfc
> > driver. I guess I'll just have to bite the bullet and add it :-)
>
> I've just posted "[PATCH] pinctrl: sh-pfc: r8a7795: Add DU support" and
> "[PATCH] arm64: dts: renesas: salvator-x: Configure pins for the DU RGB
> output". As the latter depends on the former which will be merged through a
> different tree, I propose merging this series already, and delaying "[PATCH]
> arm64: dts: renesas: salvator-x: Configure pins for the DU RGB output" to the
> next kernel version.
>
> Simon, is that fine with you ? If so, could you please pick this series up ?
Yes, I have done so and plan to push it later today.
