Re: [PATCH 6/6] media: adv7180: fix field type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07/29/2016 12:10 PM, Sergei Shtylyov wrote:
On 07/29/2016 08:40 PM, Niklas Söderlund wrote:

From: Steve Longerbeam <slongerbeam@xxxxxxxxx>

The ADV7180 and ADV7182 transmit whole fields, bottom field followed
by top (or vice-versa, depending on detected video standard). So
for chips that do not have support for explicitly setting the field
mode, set the field mode to V4L2_FIELD_ALTERNATE.

Signed-off-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx>
[Niklas: changed filed type from V4L2_FIELD_SEQ_{TB,BT} to
V4L2_FIELD_ALTERNATE]
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

Tested-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

IIUC, it's a 4th version of this patch; you should have kept the original change log (below --- tearline) and indicated that in the subject.

MBR, Sergei

This version is fine with me. The i.mx6 h/w motion-compensation deinterlacer (VDIC) needs to know the field order, and it can't get that info from V4L2_FIELD_ALTERNATE,
but it can still determine the order via querystd().

But I agree the change log should be preserved, and the V4L2_FIELD_ALTERNATE change
added to the change log.

Acked-by: Steve Longerbeam <slongerbeam@xxxxxxxxx>

Steve





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux