On Wednesday, July 6, 2016 10:23:25 PM CEST Simon Horman wrote:
>
> +static struct tmio_mmc_dma_ops tmio_dma_ops;
> +
> +void tmio_set_dma_ops(const struct tmio_mmc_dma_ops *ops)
> +{
> + tmio_dma_ops = *ops;
> +}
> +EXPORT_SYMBOL(tmio_set_dma_ops);
> +
>
Having a global instance of this pointer seems wrong, why not
store the pointer per device in struct tmio_mmc_host?
It's unlikely to ever clash between two devices in the same system,
but we generally try not to rely on that.
Arnd
