Re: [PATCH 07/39 v2] ASoC: simple-card-utils: add asoc_simple_card_parse_card_name()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mark

> > > > +	if (!card->name)
> > > > +		card->name = card->dai_link->name;
> 
> > > This will unconditionally defererence dai_link but it's optional - we
> > > can have analogue only cards.
> 
> > This is not new feature. Current simple-card already has it.
> 
> Right, but simple-card does need DAIs IIRC while this is intended to be
> more general.  All it needs is a check before the dereference to be safe
> so it's trivial to handle.

Sorry, I'm not 100% understand.
Do you mean we don't need handle card->name ? (= we should remove above ?)
If so, we can't register card on simple-card. Because snd_soc_register_card()
requests it.




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux