Re: [git pull] clk: renesas: Add support for R-Car M3-W

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stephen,

On Tue, Jun 28, 2016 at 7:13 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
> On 06/21, Geert Uytterhoeven wrote:
>> On Tue, Jun 21, 2016 at 2:51 AM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
>> > On 06/06, Geert Uytterhoeven wrote:
>> >> The following changes since commit 1a695a905c18548062509178b98bc91e67510864:
>> >>
>> >>   Linux 4.7-rc1 (2016-05-29 09:29:24 -0700)
>> >>
>> >> are available in the git repository at:
>> >>
>> >>   git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git tags/clk-renesas-for-v4.8-tag1
>> >>
>> >> for you to fetch changes up to e4e2d7c388350eba8b1dbc2569441ac9b545a8c4:
>> >>
>> >>   clk: renesas: cpg-mssr: Add support for R-Car M3-W (2016-06-06 11:58:35 +0200)
>> >>
>> >
>> > Checkpatch complains...
>> >
>> > ERROR: Use of const init definition must use __initconst
>> > #712: FILE: drivers/clk/renesas/rcar-gen3-cpg.c:248:
>> > +static const struct rcar_gen3_cpg_pll_config *cpg_pll_config __initdata;
>> >
>> > Seems like a valid problem. Any chance it can be fixed?
>>
>> It is a false positive: the data pointed to is const, the pointer
>> variable isn't.
>
> Argh thanks. It would be nice if sparse complained about that
> instead of checkpatch so that we got a better parse on the actual
> type that is marked initdata. Anyway, I see this pull is
> superseded now.

It is not; there's just a second pull request with more commits on top.

I think you best pull this one first, as git will use the summary from the
signed tag. The signed tag of the second pull request only summarizes
the additions, compared to the first tag.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux