Hi Niklas,
Thank you for the patch.
On Wednesday 15 Jun 2016 13:13:06 Niklas Söderlund wrote:
> The documentation states one should make sure both DE and TE are cleared
> before starting a transaction. This patch extends the current warning to
> look at both DE and TE.
>
> Based on previous work from Muhammad Hamza Farooq.
>
> Suggested-by: Muhammad Hamza Farooq <mfarooq@xxxxxxxxxxx>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/dma/sh/rcar-dmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> index 791a064..7f26576 100644
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -311,7 +311,7 @@ static bool rcar_dmac_chan_is_busy(struct rcar_dmac_chan
> *chan) {
> u32 chcr = rcar_dmac_chan_read(chan, RCAR_DMACHCR);
>
> - return (chcr & (RCAR_DMACHCR_DE | RCAR_DMACHCR_TE)) == RCAR_DMACHCR_DE;
> + return !!(chcr & (RCAR_DMACHCR_DE | RCAR_DMACHCR_TE));
> }
>
> static void rcar_dmac_chan_start_xfer(struct rcar_dmac_chan *chan)
--
Regards,
Laurent Pinchart
