Hi Ulrich, > Thanks for the patch, this is a lot easier to handle. > [...] > > +#define RCANFD_RFPTR_RFTS(x) (((x) >> 0) & 0xff) > > That should be "(((x) >> 0) & 0xffff)". > > > + [...] > > +/* RSCFDnCFDRMXXXq -> RCANFD_F_RMXXX(q) */ > > +#define RCANFD_F_RMID(q) (0x2000 + (0x10 * (q))) > > +#define RCANFD_F_RMPTR(q) (0x2004 + (0x10 * (q))) > > +#define RCANFD_F_RMFDSTS(q) (0x2008 + (0x10 * (q))) > > These should all be "+ (0x20 * (q))". > [...] > > Apart from that, all register addresses, offsets, bit positions and masks > check out. With the two issues fixed: > > Reviewed-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> Thank you for your time & review comments. I have fixed these typos and sent out a v7 patch set adding your Reviewed-by tag. Thanks, Ramesh
