Hi Dirk,
On Wed, Jun 1, 2016 at 9:38 AM, Dirk Behme <dirk.behme@xxxxxxxxxxxx> wrote:
> Sorry, if that was unclear. I took the example and transferred it to R-Car3
> where we have ES1 - ES3.
>
> So, taking this example, on R-Car3 we might end up with
>
> {
> .compatible = "renesas,sata-r8a7795",
> .data = (void *)RCAR_GEN2_SATA
> },
> {
> .compatible = "renesas,sata-r8a7795-es1",
> .data = (void *)RCAR_R8A7795_ES1_SATA
> },
> {
> .compatible = "renesas,sata-r8a7795-es2",
> .data = (void *)RCAR_R8A7795_ES2_SATA
> },
> {
> .compatible = "renesas,sata-r8a7795-es3",
> .data = (void *)RCAR_R8A7795_ES3_SATA
> },
Are there known differences in the SATA implementations on R-Car H3 ES1, ES2,
and ES3? If not, just "renesas,sata-r8a7795" will do.
BTW having different compatible values in the driver makes it much easier to
audit kernel sources for support for ESx deviations.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
