Hi Mark > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > simple-card like driver is supporting DPCM FE/BE. > > This patch makes this method simple style standard. > > DPCM is very much an implementation detail of the current stack, > providing helpers that promote its use doesn't seem like the best idea - > we want to change it for in kernel use going forwards and that's going > to be harder with DPCM. We should be encouraging bindings that make > DSPs look more like CODECs. rsrc-card which is using DPCM is already existing in upstream. And, sharing code between simple-card <-> rsrc-card (= simple-dpcm-card), (and expand it to simple-graph-card) is the purpose of this patch-set. So, I will drop this "DPCM specific helper function" from simple-card-core (= will be simple-card-util). But simple-dpcm-card itself is OK. Is this correct ? Best regards --- Kuninori Morimoto