RE: [PATCH 2/4] arm64: dts: salvator-x: enable usb2_phy of channel 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert-san,

> From: linux-renesas-soc-owner@xxxxxxxxxxxxxxx [mailto:linux-renesas-soc-owner@xxxxxxxxxxxxxxx] On Behalf Of Geert
> Uytterhoeven
> Sent: Tuesday, May 24, 2016 4:13 PM
> 
> Hi Shimoda-san,
> 
> On Tue, May 24, 2016 at 6:57 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > This patch also adds a regulator node for USB2.0 to handle VBUS on/off
> > by the phy-rcar-gen3-usb2 driver.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 24 ++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > index c09ead3..21e7e09 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > @@ -112,6 +112,17 @@
> >                           1800000 0>;
> >         };
> >
> > +       vbus0_usb2_phy0: regulator@5 {
> 
> "make dtbs W=1":
> 
> Warning (unit_address_vs_reg): Node /regulator@5 has a unit name, but
> no reg property

Thank you for the review!
I missed your related patch...

> regulator-vbus0-usb2-phy0? (oops, what a long name)

Hmm, I think the "-phy0" is not needed.
So, I will fix the name as "regulator-vbus0-usb2".

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux