On Wednesday 27 April 2016 03:26 PM, Arnd Bergmann wrote:
After the conversion to devm_pinctrl_register, we get a warning in sh_pfc_remove when CONFIG_PINCTRL_SH_PFC_GPIO is disabled: drivers/pinctrl/sh-pfc/core.c: In function 'sh_pfc_remove': drivers/pinctrl/sh-pfc/core.c:603:17: unused variable 'pfc' [-Werror=unused-variable] struct sh_pfc *pfc = platform_get_drvdata(pdev); This moves the variable definition inside of the same ifdef that has the only user, to get a clean build again.
Similar patch from Geert also: [PATCH] pinctrl: sh-pfc: Kill unused variable in sh_pfc_remove() If devm_gpiochip_add_data() used then this may not be required.
