Re: [PATCH 03/13] v4l: vsp1: Implement runtime PM support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thank you for the review.

On Monday 25 Apr 2016 10:24:22 Geert Uytterhoeven wrote:
> On Sun, Apr 24, 2016 at 1:49 AM, Laurent Pinchart
> 
> <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote:
> > Replace the manual refcount and clock management code by runtime PM.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > ---
> > 
> >  drivers/media/platform/Kconfig          |   1 +
> >  drivers/media/platform/vsp1/vsp1.h      |   3 -
> >  drivers/media/platform/vsp1/vsp1_drv.c  | 101 ++++++++++++---------------
> >  drivers/media/platform/vsp1/vsp1_pipe.c |   2 +-
> >  4 files changed, 54 insertions(+), 53 deletions(-)
> > 
> > diff --git a/drivers/media/platform/Kconfig
> > b/drivers/media/platform/Kconfig index f453910050be..28d0db102c0b 100644
> > --- a/drivers/media/platform/Kconfig
> > +++ b/drivers/media/platform/Kconfig
> > @@ -264,6 +264,7 @@ config VIDEO_RENESAS_VSP1
> >         tristate "Renesas VSP1 Video Processing Engine"
> >         depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
> >         depends on (ARCH_RENESAS && OF) || COMPILE_TEST
> > +       depends on PM
> 
> PM is always enabled since commits 2ee98234b88174f2 ("arm64: renesas: Enable
> PM and PM_GENERIC_DOMAINS for SoCs with PM Domains") and 71d076ceb245f0d9
> ("ARM: shmobile: Enable PM and PM_GENERIC_DOMAINS for SoCs with PM
> Domains").
> 
> Even before that, drivers/sh/pm_runtime.c would have taken care of
> enabling the clocks for you.

OK, I'll fix that. COMPILE_TEST should be handled by the pm_runtime.h stub 
functions.

-- 
Regards,

Laurent Pinchart




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux