On 22 April 2016 at 09:59, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Hi Ulf, > > On Fri, Apr 22, 2016 at 9:28 AM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: >>> @@ -217,6 +218,8 @@ static int rcar_sysc_pd_power_on(struct generic_pm_domain *genpd) >>> return rcar_sysc_power_up(&pd->ch); >>> } >>> >>> +static bool has_cpg_mstp; >>> + >> >> That's seems lazy. :-) >> >> Sure you can provide this as an input parameter to >> rcar_sysc_pd_setup() instead, no? > > This variable is intended to go away, once all R-Car SoCs have been converted > to use the CPG/MSSR driver, and has_cpg_mstp will always be false. > Then we can just remove those lines, instead of reworking the parameter > passing. Okay, that seems like a reasonable way forward. Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Kind regards Uffe
