Hi Laurent, On Sun, Apr 24, 2016 at 1:49 AM, Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote: > The FCP is a companion module of video processing modules in the > Renesas R-Car Gen3 SoCs. It provides data compression and decompression, > data caching, and conversion of AXI transaction in order to reduce the transactions > memory bandwidth. > --- /dev/null > +++ b/drivers/media/platform/rcar-fcp.c > @@ -0,0 +1,176 @@ > +/** > + * rcar_fcp_enable - Enable an FCP > + * @fcp: The FCP instance > + * > + * Before any memory access through an FCP is performed by a module, the FCP > + * must be enabled by a call to this function. The enable calls are reference > + * counted, each of them must be followed by one rcar_fcp_disable() call when > + * no more memory transfer can occur through the FCP. > + */ > +void rcar_fcp_enable(struct rcar_fcp_device *fcp) > +{ > + if (fcp) > + pm_runtime_get_sync(fcp->dev); Given pm_runtime_get_sync() returns an error code (which is usually just ignored), perhaps you want to forward that? > +} > +EXPORT_SYMBOL_GPL(rcar_fcp_enable); Regardless Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds