Hi Sakari, Do you still have issues with this patch ? On Tuesday 29 Mar 2016 10:40:05 Laurent Pinchart wrote: > On Tuesday 29 Mar 2016 02:01:55 Sakari Ailus wrote: > > On Fri, Mar 25, 2016 at 12:43:35PM +0200, Laurent Pinchart wrote: > > > Add composer, format converter and scaler functions, as well as generic > > > video processing to be used when no other processing function is > > > applicable. > > > > How are these intended to be used? > > > > Say, if a sub-device implements functionality that matches more than one > > of these, do you pick one? > > The whole point of functions is that they're not mutually exclusive, and the > full list of functions will be reported as properties for the entity. The > function field of the media entity structure stores the main function only. > > > Supposedly you control at least some of this functionality using the > > selections API, and frankly, I think the way it's currently defined in the > > spec worked okay-ish for the devices at hand at the time, but defining > > that the order of processing from the sink towards the source is sink > > crop, sink compose and then source crop is not generic. We should have a > > better way to tell this, using a similar API which is used to control the > > functionality, just as is done with V4L2 controls. > > Sure, but how is that related to this patch ? :-) > > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > > --- > > > > > > Documentation/DocBook/media/v4l/media-types.xml | 34 ++++++++++++++++++ > > > include/uapi/linux/media.h | 8 ++++++ > > > 2 files changed, 42 insertions(+) -- Regards, Laurent Pinchart
