Hello. 2016-03-27 22:02 GMT+09:00 Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>: > Hello. > > > On 03/22/2016 06:22 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@xxxxxxxxxxx> >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (timestamp, error, gPTP) >> - One interrupt for emac >> - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) >> >> This patch improve efficiency of the interrupt handler by adding the >> interrupt handler corresponding to each interrupt source described >> above. Additionally, it reduces the number of times of the access to >> EthernetAVB IF. >> Also this patch prevent this driver depends on the whim of a boot loader. >> >> [ykaneko0929@xxxxxxxxx: define bit names of registers] >> [ykaneko0929@xxxxxxxxx: add comment for gen3 only registers] >> [ykaneko0929@xxxxxxxxx: fix coding style] >> [ykaneko0929@xxxxxxxxx: update changelog] >> [ykaneko0929@xxxxxxxxx: gen3: fix initialization of interrupts] >> [ykaneko0929@xxxxxxxxx: gen3: fix clearing interrupts] >> [ykaneko0929@xxxxxxxxx: gen3: add helper function for request_irq()] >> [ykaneko0929@xxxxxxxxx: gen3: remove IRQF_SHARED flag for request_irq()] >> [ykaneko0929@xxxxxxxxx: revert ravb_close() and ravb_ptp_stop()] >> [ykaneko0929@xxxxxxxxx: avoid calling free_irq() to non-hooked interrupts] >> [ykaneko0929@xxxxxxxxx: make NC/BE interrupt handler a function] >> [ykaneko0929@xxxxxxxxx: make timestamp interrupt handler a function] >> [ykaneko0929@xxxxxxxxx: timestamp interrupt is handled in multiple >> interrupt handler instead of dma queue interrupt handler] >> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@xxxxxxxxxxx> >> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> > > [...] > > Acked-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> Many thanks for your review and much help! > > MBR, Sergei > Thanks, kaneko