Hi Simon, On Thu, Mar 17, 2016 at 11:43 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Thu, Mar 17, 2016 at 02:47:25PM +0100, Geert Uytterhoeven wrote: >> Amend the DT bindings for the Renesas SCI driver to allow describing >> optional GPIO-controlled modem lines, which can be used where dedicated >> modem lines are not available. >> >> The property naming is dictated by the SERIAL_MCTRL_GPIO helpers. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> Cc: devicetree@xxxxxxxxxxxxxxx >> --- >> Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt >> index 528c3b90f23cb04b..f8d7b36742967163 100644 >> --- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt >> +++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt >> @@ -76,6 +76,9 @@ Optional properties: >> - dmas: Must contain a list of two references to DMA specifiers, one for >> transmission, and one for reception. >> - dma-names: Must contain a list of two DMA names, "tx" and "rx". >> + - {cts,dsr,dcd,rng,rts,dtr,out1,out2}-gpios: Must contain a GPIO specifier, >> + referring to the GPIO pin to be used as the UART's CTS, DSR, DCD, RNG, RTS, >> + DTR, OUT1, or OUT2 line. >> >> Example: >> aliases { > > Hi Geert, > > I do not feel strongly about this but I wonder if it > would make sense to update the example with the new properties. These are meant to be added to the board .dts file, not to the .dtsi files. I can add an example if you like, let's hope nobody copies it blindly to a .dtsi file... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds