Re: [PATCH v3 3/7] soc: renesas: Add r8a7790 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Laurent,

On Thu, Mar 10, 2016 at 7:57 AM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>> --- /dev/null
>> +++ b/include/dt-bindings/power/r8a7790-sysc.h
>> @@ -0,0 +1,31 @@

>> +#define R8A7790_PD_SH                        16
>
> The power domain is called SH-4A in the datasheet, how about naming it
> R8A7790_PD_SH_4A ?

Thanks, wlll update (for all SoCs).

> Apart from that,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
>> +#define R8A7790_PD_RGX                       20
>> +#define R8A7790_PD_CA7_SCU           21
>> +#define R8A7790_PD_IMP                       24

Then this has to become R8A7790_PD_IMP_X4.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds