RE: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> 
> Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> writes:
> >> Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> writes:
> >> > This patch adds a condition to avoid the dereference.
> >> >
> >> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> >>
> >> is this a regression fix ? Do we need it in current -rc (it's getting
> >> late for that, actually), do we need a Cc: <stable> here ?
> >>
> >> Same questions are valid for the other patch in this series.
> >
> > Thank you for the review.
> 
> no problem :-)
> 
> > This is a potential problem fix. This issue is possible to cause the
> > first DMA supporting (e73a989 usb: renesas_usbhs: add DMAEngine
> > support) at 2011, I think.
> 
> okay, so according to git describe:
> 
> $ git describe e73a989
> v3.0-rc2-22-ge73a9891b3a1
> 
> this entered mainline on v3.1. This means you need to add:
> 
> Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support")
> Cc: <stable@xxxxxxxxxxxxxxx> # v3.1+
> 
> to your commit log, right before your Signed-off-by.
> 
> > We don't need in current -rc because I also think this is too late for
> > it.  I'm not sure we need a CC here.
> 
> okay, so I'll queue this once v4.6-rc1 is merged. But please resend with
> the changes above. Let me know if you need any further clarification.

Thank you very much for the detail.
I will send v2 patches with the changes above.

Best regards,
Yoshihiro Shimoda

> --
> balbi



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux