Hello. On 3/9/2016 2:09 PM, Linus Walleij wrote:
The 'ravb' Ethernet driver couldn't connect to the PHY as the MDIO bus appeared empty on the Renesas R-Car boards. The bug hunt finally pointed at the commit adding the "init" pintcrl state: it tries to switch to non- default state before the driver probe which should fail but doesn't as the PFC pinctrl driver happens to call pinctrl_provide_dummies() which makes all state lookups succeed, even though the state doesn't really exist. That feature is only relevant to non-DT systems and all the ARM boards that use the PFC driver have been converted to the DT boot, so limiting it to the SuperH architecture seems The Right Thing... Fixes: ef0eebc05130 ("drivers/pinctrl: Add the concept of an "init" state") Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> CC: stable@xxxxxxxxxxxxxxxPutting this on hold because another patch is being discussed as a more proper fix.
Sigh, I had that variant of the fix too but erroneously thought that of_have_populated_dt() could only be used with CONFIG_OF=y, so didn't publish that variant... Had no idea someone else's working on the same issue.
Yours, Linus Walleij
MBR, Sergei
