Re: [PATCH] Remove ARCH_SHMOBILE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

On Wed, Mar 2, 2016 at 2:55 AM, Simon Horman <horms+renesas@xxxxxxxxxxxx> wrote:
> [PATCH] Remove ARCH_SHMOBILE

Please use a more appropriate one-line summary.

> Since the removal of legacy (non-multiplatform) support this driver has not
> been used by any Renesas ARM based SoCs.
>
> This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
> appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
>
> Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> ---
>  drivers/input/keyboard/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>  Based on v4.5-rc1
>
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index ddd8148d51d7..984532c6e689 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -560,7 +560,7 @@ config KEYBOARD_SUNKBD
>
>  config KEYBOARD_SH_KEYSC
>         tristate "SuperH KEYSC keypad support"
> -       depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> +       depends on SUPERH || COMPILE_TEST

I think dropping the SUPERH dependency is the right approach here, as all
SuperH platforms using the driver select ARCH_SHMOBILE.

"sh_keysc" is used on SH_MIGOR, SH_ECOVEC, SH_KFR2R09, SH_7722_SOLUTION_ENGINE,
and SH_7724_SOLUTION_ENGINE, which depend on either CPU_SUBTYPE_SH7722 or
CPU_SUBTYPE_SH7724, and both select ARCH_SHMOBILE.

>         help
>           Say Y here if you want to use a keypad attached to the KEYSC block
>           on SuperH processors such as sh7722 and sh7343.

FWIW, this has never been enabled on sh7343. But CPU_SUBTYPE_SH7343 also
selects ARCH_SHMOBILE, so we're safe.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux