Hi Geert, > On Mon, Feb 29, 2016 at 10:21 AM, Ramesh Shanmugasundaram > <ramesh.shanmugasundaram@xxxxxxxxxxxxxx> wrote: > > --- a/drivers/net/can/rcar_can.c > > +++ b/drivers/net/can/rcar_can.c > > @@ -808,6 +808,10 @@ static int rcar_can_probe(struct platform_device > *pdev) > > priv->regs = addr; > > priv->clock_select = clock_select; > > priv->can.clock.freq = clk_get_rate(priv->can_clk); > > + > > + /* Use the rounded clock value (nearest kHz) */ > > + priv->can.clock.freq = 1000 * > > + DIV_ROUND_UP(priv->can.clock.freq, 1000); > > The comment and the implementation don't match. > To get the nearest kHz, you have to useDIV_ROUND_CLOSEST(). Thanks Geert. Yes, DIV_ROUND_CLOSEST() would be apt as you pointed out. I'll be removing this hack when I rebase, as Marc is fixing the algorithm. Thanks, Ramesh
