Re: [PATCH][CFT]: dmaengine: make slave address physical

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vinod,

On Sun, Feb 21, 2016 at 4:20 PM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
> The slave dmaengine semantics required the client to map dma
> addresses and pass DMA address to dmaengine drivers. While this
> was a convenient notion coming from generic dma offload cases
> where dmaengines are interchangeable and client is not aware of
> which engine to map to.
>
> But in case of slave, we know the dmaengine and always use a
> specific one. Further the IOMMU cases can lead to failure of this
> notion, so make this as physical address and now dmaengine driver
> will do the required mapping.

Thanks a lot!

> Original-patch-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

You've dropped a few ;-)

    Original-patch-acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
    Original-patch-acked-by: Arnd Bergmann <arnd@xxxxxxxx>

> Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxx>

Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> ---
>  include/linux/dmaengine.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 16a1cad30c33..d85ecd20af50 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -357,8 +357,8 @@ enum dma_slave_buswidth {
>   */
>  struct dma_slave_config {
>         enum dma_transfer_direction direction;
> -       dma_addr_t src_addr;
> -       dma_addr_t dst_addr;
> +       phys_addr_t src_addr;
> +       phys_addr_t dst_addr;
>         enum dma_slave_buswidth src_addr_width;
>         enum dma_slave_buswidth dst_addr_width;
>         u32 src_maxburst;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux