On 11 February 2016 at 01:07, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: >> I suspect you are using a delayed work in this driver to deal with >> request timeouts. >> >> The value for the delay that is used, needs to be informed towards the >> mmc core via the "->max_busy_timeout". > > Shouldn't that be a seperate patch? In patch 9, I add support for > another SoC. But your requested change will affect all SoCs. This is related to how the core treat hosts that announces MMC_CAP_WAIT_WHILE_BUSY. Therefore max_busy_timeout needs to be set within the same patch. > >> One more thing, as the documentation of your host controllers lacks >> some information about the busy mode, perhaps it's worth to add some >> comments about this in the code and as well in the change-log!? > > Do you mean documenting my findings with the mmc_test driver? Or > something else? It doesn't have to be very much data, just that the documentation isn't clear and therefore some tests has been done to verify that it works as expected. Kind regards Uffe
