Re: [PATCH 5/5] ARM: dts: r8a7794 add sound support

[Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>]

On 2/9/2016 3:08 AM, Kuninori Morimoto wrote:

> > Define the generic R8A7794 part of  the sound device node.
> > This sound device  is a complex one and comprises the Audio Clock Generator
> > (ADG), Sampling Rate Converter Unit (SCU), Serial Sound Interface [Unit]
> > (SSI[U]), and Audio DMAC-Peripheral-Peripheral.
> > It is up  to the board file to enable the device.
> >
> > This patch is based on the R8A7791 sound work by Kuninori Morimoto.
> >
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> (snip)
> > +		clocks = <&mstp10_clks R8A7794_CLK_SSI_ALL>,
> > +			 <&mstp10_clks R8A7794_CLK_SSI9>,
> > +			 <&mstp10_clks R8A7794_CLK_SSI8>,
> > +			 <&mstp10_clks R8A7794_CLK_SSI7>,
> > +			 <&mstp10_clks R8A7794_CLK_SSI6>,
> > +			 <&mstp10_clks R8A7794_CLK_SSI5>,
> > +			 <&mstp10_clks R8A7794_CLK_SSI4>,
> > +			 <&mstp10_clks R8A7794_CLK_SSI3>,
> > +			 <&mstp10_clks R8A7794_CLK_SSI2>,
> > +			 <&mstp10_clks R8A7794_CLK_SSI1>,
> > +			 <&mstp10_clks R8A7794_CLK_SSI0>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_SRC9>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_SRC8>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_SRC7>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_SRC6>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_SRC5>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_SRC4>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_SRC3>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_SRC2>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_SRC1>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_SRC0>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_CTU0_MIX0>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_CTU1_MIX1>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_CTU0_MIX0>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_CTU1_MIX1>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_DVC0>,
> > +			 <&mstp10_clks R8A7794_CLK_SCU_DVC1>,
> > +			 <&audio_clka>, <&audio_clkb>, <&audio_clkc>,
> > +			 <&m2_clk>;
> > +		clock-names = "ssi-all",
> > +			      "ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5",
> > +			      "ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0",
> > +			      "src.9", "src.8", "src.7", "src.6", "src.5",
> > +			      "src.4", "src.3", "src.2", "src.1", "src.0",
> > +			      "clk_a", "clk_b", "clk_c", "clk_i";
>
> This patch doesn't support "CTU/MIX/DVC".

   It doesn't.

> Your "clocks" includes "R8A7794_CLK_SCU_CTUx_MIXx", and "R8A7794_CLK_SCU_DVCx",
> but "clock-names" doesn't include "ctu.x", "dvc.x".

   Oops, thank you for noticing. Will fix.

MBR, Sergei