On Thu, Jan 28, 2016 at 4:37 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: >> diff --git a/arch/arm/mach-shmobile/platsmp-scu.c >> b/arch/arm/mach-shmobile/platsmp-scu.c >> index 64663110ab6ca0e1..f2198c9c74359736 100644 >> --- a/arch/arm/mach-shmobile/platsmp-scu.c >> +++ b/arch/arm/mach-shmobile/platsmp-scu.c >> @@ -17,6 +17,9 @@ >> #include <asm/smp_scu.h> >> #include "common.h" >> >> + > > Why add 2nd empty line? I always leave two blank lines between different sections, and one blank line between function or data blocks. Is that a problem? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds