On Thu, Jan 28, 2016 at 05:35:07AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > as discussed briefly last week I am having some trouble enabling thermal > > for the r8a7794/alt. With this patch applied on top of > > renesas-devel-20160127-v4.5-rc1 I see: > > > > # dmesg | grep thermal > > [ 1.089897] rcar_thermal e61f0000.thermal: thermal sensor was broken > > [ 1.101225] rcar_thermal: probe of e61f0000.thermal failed with error -22 > > Hmm... strange > It can happen if thermal didn't work. > It seems driver can't read data from register. > > > I also see this with "[PATCH] thermal: core: don't call unsupported trip on > > thermal_tripped_notify()" applied. > > Oops, really ? > I think you can't apply it on renesas-devel-20160127-v4.5-rc1 Yes, you are correct. What I did try was: "[PATCH] thermal: of-thermal: return -EAGAIN until thermal_zone_of_sensor_register() was called" > # I'm not sure why, but latest thermal branch, linus/master, linux-next/master > # doesn't have problem patch 850ddee1144("thermal: improve hot trip handling") > # So above patch is not needed > > > IS this a kernel issue that you are aware of? > > Is there a possibility that there is a problem with my hardware? > > I think this is r8a7794 specific issue, but your patch looks sane for me... > > > Any insight would be greatly appreciated. > > > > AFIK this is not urgent. [snip]