Re: [PATCH 1/2] ARM: dts: r8a7793: add CAN clocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 22, 2016 at 08:46:37AM +0100, Geert Uytterhoeven wrote:
> On Fri, Jan 22, 2016 at 1:48 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> >> > > --- a/arch/arm/boot/dts/r8a7793.dtsi
> >> > > +++ b/arch/arm/boot/dts/r8a7793.dtsi
> >> > > @@ -706,12 +706,30 @@
> >> > >                         clock-output-names = "extal";
> >> > >                 };
> >> > >
> >> > > +               /* External USB clock - can be overridden by the board */
> >> > > +               usb_extal_clk: usb_extal_clk {
> >> > > +                       compatible = "fixed-clock";
> >> > > +                       #clock-cells = <0>;
> >> > > +                       clock-frequency = <48000000>;
> >> > > +                       clock-output-names = "usb_extal";
> >> > > +               };
> >> > > +
> >> > > +               /* External CAN clock */
> >> > > +               can_clk: can_clk {
> >> > > +                       compatible = "fixed-clock";
> >> > > +                       #clock-cells = <0>;
> >> > > +                       /* This value must be overridden by the board. */
> >> > > +                       clock-frequency = <0>;
> >> > > +                       clock-output-names = "can_clk";
> >> > > +                       status = "disabled";
> >> > > +               };
> >> > > +
> >> > >                 /* Special CPG clocks */
> >> > >                 cpg_clocks: cpg_clocks@e6150000 {
> >> > >                         compatible = "renesas,r8a7793-cpg-clocks",
> >> > >                                      "renesas,rcar-gen2-cpg-clocks";
> >> > >                         reg = <0 0xe6150000 0 0x1000>;
> >> > > -                       clocks = <&extal_clk>;
> >> > > +                       clocks = <&extal_clk &usb_extal_clk>;
> >> > >                         #clock-cells = <1>;
> >> > >                         clock-output-names = "main", "pll0", "pll1", "pll3",
> >> > >                                              "lb", "qspi", "sdh", "sd0", "z",
> >> >
> >> > To create the "rcan" clock, it should be listed in clock-output-names.
> >
> > Checking this morning I see that it is already there.
> > The next line of the file is:
> >
> >                                              "rcan", "adsp";
> 
> I stand corrected.
> 
> BTW, that means you saw "failed to register ... rcan" messages
> before?

Yes, I checked and I see:

rcar_gen2_cpg_clocks_init: failed to register cpg_clocks rcan clock (-12)



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux