Hi Sergei, On Saturday 23 January 2016 22:41:36 Sergei Shtylyov wrote: > On 01/22/2016 03:57 AM, Laurent Pinchart wrote: > > Now that the subdev crop API is considered obsolete, the selection API > > that replaces it deserves a full documentation instead of referring to > > the crop API documentation. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > --- > > > > .../media/v4l/vidioc-subdev-g-selection.xml | 37 ++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > > > diff --git a/Documentation/DocBook/media/v4l/vidioc-subdev-g-selection.xml > > b/Documentation/DocBook/media/v4l/vidioc-subdev-g-selection.xml index > > c62a7360719b..9b59b49db0c3 100644 > > --- a/Documentation/DocBook/media/v4l/vidioc-subdev-g-selection.xml > > +++ b/Documentation/DocBook/media/v4l/vidioc-subdev-g-selection.xml > > @@ -69,6 +69,43 @@ > > more information on how each selection target affects the image > > processing pipeline inside the subdevice.</para> > > > > + <para>To retrieve a current selection rectangle applications set the > > + <structfield>pad</structfield> field of a &v4l2-subdev-selection; to > > the > > + desired pad number as reported by the media API, the > > + <structfield>which</structfield> field to > > + <constant>V4L2_SUBDEV_FORMAT_ACTIVE</constant> and the > > + <structfield>target</structfield> to the target selection rectangle. > > They > > + then call the <constant>VIDIOC_SUBDEV_G_SELECTION</constant> ioctl > > with a > > + pointer to this structure. The driver fills the members of the > > + <structfield>r</structfield> field or returns &EINVAL; if the input > > Isn't EINVAL constant too? Or is & the same as specifying <constant>? &EINVAL; references the entity named EINVAL, which is defined in a file generated by Documentation/DocBook/media/Makefile. It resolves to <!ENTITY EINVAL "<errorcode>EINVAL</errorcode> error code"> -- Regards, Laurent Pinchart
