On Tue, Feb 18, 2025 at 5:56 PM Frank Li <Frank.li@xxxxxxx> wrote: > > On Tue, Feb 18, 2025 at 10:57:09AM +0200, Daniel Baluta wrote: > > Current code supports EARC PHY Software Reset and EARC Software > > Reset but it is not easily extensible to more reset bits. > > > > So, refactor the code in order to easily allow more reset bits > > in the future. > > Nit: wrap at 75 chars > > > > > Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx> > > --- > > drivers/reset/reset-imx8mp-audiomix.c | 53 ++++++++++++++++++++++----- > > 1 file changed, 43 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c > > index 1fe21980a66c..6b1666c4e069 100644 > > --- a/drivers/reset/reset-imx8mp-audiomix.c > > +++ b/drivers/reset/reset-imx8mp-audiomix.c > > @@ -12,7 +12,30 @@ > > #include <linux/reset-controller.h> > > > > #define IMX8MP_AUDIOMIX_EARC_OFFSET 0x200 > > -#define IMX8MP_AUDIOMIX_EARC_RESET_MASK 0x3 > > +#define IMX8MP_AUDIOMIX_EARC_RESET_MASK 0x1 > > +#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK 0x2 > > + > > +#define IMX8MP_AUDIOMIX_EARC 0 > > +#define IMX8MP_AUDIOMIX_EARC_PHY 1 > > > Does dt binding need such macro? > > If not, you can use enum. > If yes, create binding header file for it. Thanks Philipp, Peng and Frank for your comments. All are valid. Will fix them in v2.
