Missed few changelog. Adding below.
On 03/01/25 15:42, Beleswar Padhi wrote:
This series refactors a lot of functions & callbacks from ti_k3_dsp_remoteproc.c
and ti_k3_m4_remoteproc.c drivers. This is the third and final series as part of
the refactoring of K3 remoteproc drivers. The patches for internal refactoring
and bug fixes of TI K3 R5 remoteproc driver has been already posted[0][1]. Since
the R5 driver has worked out separate data structures and reset logic than the
DSP/M4 drivers, I have excluded R5 from this refactoring.
NOTE:
This series is _dependent_ upon the [PATCH 2/3] of below series:
https://lore.kernel.org/all/20241224091457.1050233-3-b-padhi@xxxxxx/
Testing Done:
1. Tested boot of C66x DSPs, C71x DSPs across Jacinto J7* devices in Remoteproc
mode and IPC-Only mode.
2. Tested boot of M4F core _only_ in _AM62xx SK_ board in Remoteproc mode and
IPC-Only mode.
3. Tested Core stop and detach operations from sysfs for C66x DSPs, C71x DSPs
and M4F.
4. Tested device removal paths by executing 'modprobe -r ti_k3_dsp_remoteproc'
and 'modprobe -r ti_k3_m4_remoteproc'.
5. Tested usecases where firmware not available at device probe time, but later
in sysfs, able to load firmware into a remotecore and start it. [C66x, C71x, M4]
6. Tested that each patch in this series generates no new warnings/errors.
v8: Changelog:
1. Broken down refactoring into patches, each patch dealing with one function
for ease in review. [Andrew]
2. Introduced checks to prevent mailbox IPC with detached M4 core.
3. Refined reset/release from reset logic for DSP cores that do not have
a local reset in PATCH #6 and PATCH #7 of this series.
4. Refactored additional .start()/.stop()/.attach()/.detach()/mbox
.rx_callback()/request_mbox() functions in this series.
Thanks,
Beleswar
Links to older versions:
v7: https://lore.kernel.org/all/20240202175538.1705-1-hnagalla@xxxxxx/
v6: https://lore.kernel.org/all/20230913111644.29889-1-hnagalla@xxxxxx/
v5: https://lore.kernel.org/all/20230808044529.25925-1-hnagalla@xxxxxx/
v4: https://lore.kernel.org/all/20230801141117.2559-1-hnagalla@xxxxxx/
v3: https://lore.kernel.org/all/20230302171450.1598576-1-martyn.welch@xxxxxxxxxxxxx/
v2: https://lore.kernel.org/all/20230301111323.1532479-4-martyn.welch@xxxxxxxxxxxxx/
v1: https://lore.kernel.org/all/20220110040650.18186-1-hnagalla@xxxxxx/
Thanks,
Beleswar
[0]: https://lore.kernel.org/all/20241219110545.1898883-1-b-padhi@xxxxxx/
[1]: https://lore.kernel.org/all/20241224091457.1050233-1-b-padhi@xxxxxx/
Beleswar Padhi (20):
remoteproc: k3-m4: Prevent Mailbox level IPC with detached core
remoteproc: k3: Refactor shared data structures
remoteproc: k3: Refactor mailbox rx_callback functions into common
driver
remoteproc: k3: Refactor .kick rproc ops into common driver
remoteproc: k3-m4: Use k3_rproc_mem_data structure for memory info
remoteproc: k3: Refactor rproc_reset() implementation into common
driver
remoteproc: k3: Refactor rproc_release() implementation into common
driver
remoteproc: k3: Refactor rproc_request_mbox() implementations into
common driver
remoteproc: k3: Refactor .prepare rproc ops into common driver
remoteproc: k3: Refactor .unprepare rproc ops into common driver
remoteproc: k3: Refactor .start rproc ops into common driver
remoteproc: k3: Refactor .stop rproc ops into common driver
remoteproc: k3: Refactor .attach rproc ops into common driver
remoteproc: k3: Refactor .detach rproc ops into common driver
remoteproc: k3: Refactor .get_loaded_rsc_table ops into common driver
remoteproc: k3: Refactor .da_to_va rproc ops into common driver
remoteproc: k3: Refactor of_get_memories() functions into common
driver
remoteproc: k3: Refactor mem_release() functions into common driver
remoteproc: k3: Refactor reserved_mem_init() functions into common
driver
remoteproc: k3: Refactor release_tsp() functions into common driver
drivers/remoteproc/Makefile | 4 +-
drivers/remoteproc/ti_k3_common.c | 586 ++++++++++++++++++++
drivers/remoteproc/ti_k3_common.h | 113 ++++
drivers/remoteproc/ti_k3_dsp_remoteproc.c | 643 +---------------------
drivers/remoteproc/ti_k3_m4_remoteproc.c | 583 ++------------------
5 files changed, 765 insertions(+), 1164 deletions(-)
create mode 100644 drivers/remoteproc/ti_k3_common.c
create mode 100644 drivers/remoteproc/ti_k3_common.h
