On 4.10.2024 11:23 PM, Mukesh Ojha wrote: > Qualcomm SoCs running with the Qualcomm EL2 hypervisor(QHEE) have been > utilizing the Peripheral Authentication Service (PAS) from its TrustZone > (TZ) firmware to securely authenticate and reset via sequence of SMC > calls like qcom_scm_pas_init_image(), qcom_scm_pas_mem_setup(), and > qcom_scm_pas_auth_and_reset(). > > Memory protection need to be enabled for both meta data memory region and > remoteproc carveout memory region. Will TZ refuse to start the remoteprocs if this is not the case? > For memory passed to Qualcomm TrustZone, the memory should be part of > SHM bridge memory. However, when QHEE is present, PAS SMC calls are > getting trapped in QHEE, which create or gets memory from SHM bridge for > both meta data memory and for remoteproc carve out regions before it get > passed to TZ. However, in absence of QHEE hypervisor, Linux need to > create SHM bridge for both meta data in qcom_scm_pas_init_image() and > for remoteproc memory before the call being made to > qcom_scm_pas_auth_and_reset(). > > For qcom_scm_pas_init_image() call, metadata content need to be copied > to the buffer allocated from SHM bridge before making the SMC call. > > For qcom_scm_pas_auth_and_reset(), remoteproc memory region need to be > protected and for that SHM bridge need to be created. Make > qcom_tzmem_init_area() and qcom_tzmem_cleanup_area() exported symbol so > that it could be used to create SHM bridge for remoteproc region. > > Signed-off-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx> > --- > drivers/firmware/qcom/qcom_scm.c | 29 +++++++++++----- > drivers/firmware/qcom/qcom_tzmem.c | 14 +++----- > drivers/remoteproc/qcom_q6v5_pas.c | 44 ++++++++++++++++++++++++ > include/linux/firmware/qcom/qcom_scm.h | 1 + > include/linux/firmware/qcom/qcom_tzmem.h | 10 ++++++ > 5 files changed, 80 insertions(+), 18 deletions(-) This changes files in two separate subsystems. That implies this patch should be split in two. Or three. > > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c > index 10986cb11ec0..dafc07dc181f 100644 > --- a/drivers/firmware/qcom/qcom_scm.c > +++ b/drivers/firmware/qcom/qcom_scm.c > @@ -591,15 +591,19 @@ int qcom_scm_pas_init_image(u32 peripheral, const void *metadata, size_t size, > * data blob, so make sure it's physically contiguous, 4K aligned and > * non-cachable to avoid XPU violations. > * > - * For PIL calls the hypervisor creates SHM Bridges for the blob > - * buffers on behalf of Linux so we must not do it ourselves hence > - * not using the TZMem allocator here. > + * For PIL calls the hypervisor like Gunyah or older QHEE creates SHM > + * Bridges for the blob buffers on behalf of Linux so we must not do it > + * ourselves hence use TZMem allocator only when these hypervisors are > + * not present. This is a bit hard to read.. How about: PIL calls require SHMBridge is set up for shared memory regions. Qualcomm hypervisors (Gunyah, QHEE) already take care of this. Only create new bridges if they're absent. [...] Konrad
