On Mon, Oct 14, 2024, at 14:56, Andrew Davis wrote: > On 10/7/24 8:23 AM, Arnd Bergmann wrote: >> config TI_K3_M4_REMOTEPROC >> tristate "TI K3 M4 remoteproc support" >> - depends on ARCH_OMAP2PLUS || ARCH_K3 >> - select MAILBOX >> - select OMAP2PLUS_MBOX >> + depends on ARCH_K3 || COMPILE_TEST >> + depends on TI_SCI_PROTOCOL || (COMPILE_TEST && TI_SCI_PROTOCOL=n) > > This line is odd. IMHO "COMPILE_TEST" should only be added to ARCH_* > dependencies, as often only one ARCH can be selected which prevents > compile testing drivers with various multiple architecture deps in > one compile test. I generally agree, but the TI_SCI_PROTOCOL interface definitions that were added in aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol") appear to explicitly support the case of compile-testing. See also 13678f3feb30 ("reset: ti-sci: honor TI_SCI_PROTOCOL setting when not COMPILE_TEST"). > Normal dependencies, on the other hand, can simply be enabled if one > wants to compile test its dependent drivers. In this case, TI_SCI_PROTOCOL > cannot be enabled as it has a dependency up the chain that doesn't > allow selecting when not on a TI platform. We can fix that as I posted > here[0]. With that fix in, this line can be simply become: > > depends on TI_SCI_PROTOCOL That's certainly fine with me, but if we do this, I would suggest also removing the stub functions from include/linux/soc/ti/ti_sci_protocol.h, and the dependency in the reset driver. Adding Nishanth Menon to Cc, to see if he has a preference. Arnd