Hi,
On Thu, Sep 05, 2024 at 08:05:01PM +0800, Zhang Zekun wrote:
> platform_get_resource_byname() and devm_ioremap_resource() can be
> replaced by devm_platform_ioremap_resource_byname(), which can
> simplify the code logic a bit, No functional change here.
>
> Signed-off-by: Zhang Zekun <zhangzekun11@xxxxxxxxxx>
> ---
> drivers/remoteproc/st_slim_rproc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/remoteproc/st_slim_rproc.c b/drivers/remoteproc/st_slim_rproc.c
> index d17719384c16..5412beb0a692 100644
> --- a/drivers/remoteproc/st_slim_rproc.c
> +++ b/drivers/remoteproc/st_slim_rproc.c
> @@ -259,16 +259,14 @@ struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev,
> slim_rproc->mem[i].size = resource_size(res);
> }
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "slimcore");
> - slim_rproc->slimcore = devm_ioremap_resource(dev, res);
> + slim_rproc->slimcore = devm_platform_ioremap_resource_byname(pdev, "slimcore");
> if (IS_ERR(slim_rproc->slimcore)) {
> dev_err(&pdev->dev, "failed to ioremap slimcore IO\n");
> err = PTR_ERR(slim_rproc->slimcore);
> goto err;
> }
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "peripherals");
> - slim_rproc->peri = devm_ioremap_resource(dev, res);
> + slim_rproc->peri = devm_platform_ioremap_resource_byname(pdev, "peripherals");
There are several instances of the above in other drivers of the remoteproc
susbsystem. Please send another patch with those corrected as well.
Thanks,
Mathieu
> if (IS_ERR(slim_rproc->peri)) {
> dev_err(&pdev->dev, "failed to ioremap peripherals IO\n");
> err = PTR_ERR(slim_rproc->peri);
> --
> 2.17.1
>
