Re: [PATCH v8 1/4] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 25, 2024 at 02:03:36PM -0500, Andrew Davis wrote:
> On 4/25/24 12:15 PM, Conor Dooley wrote:
> > On Wed, Apr 24, 2024 at 03:36:39PM -0500, Rob Herring wrote:
> > > 
> > > On Wed, 24 Apr 2024 14:06:09 -0500, Andrew Davis wrote:
> > > > From: Hari Nagalla <hnagalla@xxxxxx>
> > > > 
> > > > K3 AM64x SoC has a Cortex M4F subsystem in the MCU voltage domain.
> > > > The remote processor's life cycle management and IPC mechanisms are
> > > > similar across the R5F and M4F cores from remote processor driver
> > > > point of view. However, there are subtle differences in image loading
> > > > and starting the M4F subsystems.
> > > > 
> > > > The YAML binding document provides the various node properties to be
> > > > configured by the consumers of the M4F subsystem.
> > > > 
> > > > Signed-off-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxx>
> > > > Signed-off-by: Hari Nagalla <hnagalla@xxxxxx>
> > > > Signed-off-by: Andrew Davis <afd@xxxxxx>
> > > > ---
> > > >   .../bindings/remoteproc/ti,k3-m4f-rproc.yaml  | 126 ++++++++++++++++++
> > > >   1 file changed, 126 insertions(+)
> > > >   create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml
> > > > 
> > > 
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > 
> > > 
> > > doc reference errors (make refcheckdocs):
> > > Warning: Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml references a file that doesn't exist: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml
> > > Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml: Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml
> > 
> > The file is now in dt-schema:
> > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/reserved-memory/reserved-memory.yaml
> 
> So should I use "reserved-memory/reserved-memory.yaml" here, or just
> drop this line completely?

The only other example that I could find that didn't reference the text
binding (which points to dt-schema) said:
"(see reserved-memory/reserved-memory.yaml in dtschema project)"

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Photo Sharing]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux