Re: [PATCH v6 3/6] soc: qcom: pdr: extract PDR message marshalling data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 23 Apr 2024 at 01:21, Steev Klimaszewski <steev@xxxxxxxx> wrote:
>
> Hi Dmitry,
>
> On Mon, Apr 22, 2024 at 5:11 AM Dmitry Baryshkov
> <dmitry.baryshkov@xxxxxxxxxx> wrote:
> >
> > The in-kernel PD mapper is going to use same message structures as the
> > QCOM_PDR_HELPERS module. Extract message marshalling data to separate
> > module that can be used by both PDR helpers and by PD mapper.
> >
> > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> >  drivers/soc/qcom/Kconfig        |   4 +
> >  drivers/soc/qcom/Makefile       |   1 +
> >  drivers/soc/qcom/pdr_internal.h | 306 ++------------------------------------
> >  drivers/soc/qcom/qcom_pdr_msg.c | 315 ++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 330 insertions(+), 296 deletions(-)
>
> <snip>
>
> > diff --git a/drivers/soc/qcom/qcom_pdr_msg.c b/drivers/soc/qcom/qcom_pdr_msg.c
> > new file mode 100644
> > index 000000000000..a8867e8b1319
> > --- /dev/null
> > +++ b/drivers/soc/qcom/qcom_pdr_msg.c

[skipped]

> >
> > --
> > 2.39.2
> >
> This is missing MODULE_LICENSE
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/soc/qcom/qcom_pdr_msg.o

Argh. Fine, fine. I'll switch to a modular kernel config.

-- 
With best wishes
Dmitry





[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Photo Sharing]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux