On Sun, 21 Apr 2024 at 02:42, Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx> wrote: > > On 19/04/2024 15:00, Dmitry Baryshkov wrote: > > The in-kernel PD mapper is going to use same message structures as the > > QCOM_PDR_HELPERS module. Extract message marshalling data to separate > > module that can be used by both PDR helpers and by PD mapper. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > @@ -0,0 +1,315 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2020 The Linux Foundation. All rights reserved. > > + */ > > Is this the right org attributed ? Definitely not the right year/years. Yes, it is the right org & year. While the pdr_internal.h header (from which these definitions were moved) didn't contain copyright, the pdr_interface.c file was a part of the commit that brought the header file in. The file contained this copyright header. Thus I assume the most correct action is to use it for the new source file. > > Please fix, then. > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> -- With best wishes Dmitry
