On Thu, 2024-03-28 at 16:03 +0800, Xuan Zhuo wrote: > Now, we pass multi parameters to find_vqs. These parameters > may work for transport or work for vring. > > And find_vqs has multi implements in many places: > > arch/um/drivers/virtio_uml.c > drivers/platform/mellanox/mlxbf-tmfifo.c > drivers/remoteproc/remoteproc_virtio.c > drivers/s390/virtio/virtio_ccw.c > drivers/virtio/virtio_mmio.c > drivers/virtio/virtio_pci_legacy.c > drivers/virtio/virtio_pci_modern.c > drivers/virtio/virtio_vdpa.c > > Every time, we try to add a new parameter, that is difficult. > We must change every find_vqs implement. > > One the other side, if we want to pass a parameter to vring, > we must change the call path from transport to vring. > Too many functions need to be changed. > > So it is time to refactor the find_vqs. We pass a structure > cfg to find_vqs(), that will be passed to vring by transport. > > Because the vp_modern_create_avq() use the "const char *names[]", > and the virtio_uml.c changes the name in the subsequent commit, so > change the "names" inside the virtio_vq_config from "const char > *const > *names" to "const char **names". > > Signed-off-by: Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx> > Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > Acked-by: Jason Wang <jasowang@xxxxxxxxxx> > --- > arch/um/drivers/virtio_uml.c | 22 +++---- > drivers/platform/mellanox/mlxbf-tmfifo.c | 13 ++-- > drivers/remoteproc/remoteproc_virtio.c | 25 ++++---- > drivers/s390/virtio/virtio_ccw.c | 28 ++++----- > drivers/virtio/virtio_mmio.c | 23 ++++--- > drivers/virtio/virtio_pci_common.c | 57 ++++++++---------- > drivers/virtio/virtio_pci_common.h | 9 +-- > drivers/virtio/virtio_pci_legacy.c | 11 ++-- > drivers/virtio/virtio_pci_modern.c | 32 ++++++---- > drivers/virtio/virtio_vdpa.c | 33 +++++----- > include/linux/virtio_config.h | 76 ++++++++++++++++++---- > -- > 11 files changed, 175 insertions(+), 154 deletions(-) Acked-by: Eric Farman <farman@xxxxxxxxxxxxx> # s390
