On Mon, Mar 11, 2024 at 05:34:05PM +0200, Dmitry Baryshkov wrote: > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c [..] > static int qcom_rproc_pds_attach(struct qcom_adsp *adsp, const char **pd_names, > @@ -375,10 +382,14 @@ static int adsp_start(struct rproc *rproc) > int ret; > unsigned int val; > > - ret = qcom_q6v5_prepare(&adsp->q6v5); > + ret = qcom_pdm_add_domains(adsp->domains, adsp->num_domains); As we're not defining the PDs based on the loaded firmware, and you're doing the reinitialization-dance of the server on each add/remove of domains I think it would be better to just register these at probe time. Regards, Bjorn
