On 3/12/24 7:10 AM, Krzysztof Kozlowski wrote: > On 11/03/2024 17:27, Tanmay Shah wrote: > >>> + then: > >>> + patternProperties: > >>> + "^r5f@[0-9a-f]+$": > >>> + type: object > >>> + > >>> + properties: > >>> + reg: > >>> + minItems: 1 > >>> + items: > >>> + - description: ATCM internal memory > >>> + - description: BTCM internal memory > >>> + - description: extra ATCM memory in lockstep mode > >>> + - description: extra BTCM memory in lockstep mode > >>> + > >>> + reg-names: > >>> + minItems: 1 > >>> + items: > >>> + - const: atcm0 > >>> + - const: btcm0 > >>> + - const: atcm1 > >>> + - const: btcm1 > >> > >> Why power domains are flexible? > > > > User may not want to use all the TCMs. For example, if users want to turn-on only TCM-A and rest of them want to keep off, then > > > > they can avoid having power-domains of other TCMs in the device-tree. This helps with less power-consumption when needed. > > > > Hence flexible list of power-domains list. > > > > Isn't turning on/off driver's job? Sorry, but what is "user" here? DTS > describes bindings, not OS policy. Thanks for reviews. Correct driver turns on off TCM. However, system designers (users) have option to not include TCM that is not needed in device-tree. So power-domains are flexible, same as reg, and reg-names. ATCM is always needed as vector table is in ATCM. R5 core power domain and ATCM power-domain for each core is always required so minItems 2. > Also, please wrap your replies to match email style. > > > I can certainly mention "items:" under power-domains property. > > > > > >> > > > Best regards, > Krzysztof >
