Re: [PATCH v4 3/7] soc: qcom: add pd-mapper implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 12, 2024 at 01:55:27AM +0100, Konrad Dybcio wrote:

> One suggestion I have is to use cleanup.h and scoped guards to
> save on some LoC

LoC is not the best metric for code quality, it really depends on if it
makes the code more readable or not. Often being explicit, so that it's
obvious what is going on, is preferred even if it adds a few more lines
(c.f. all the ways that people manage to use devres wrong).

After just skimming this patch, I don't see that there would be any
benefit from using scoped guards.

Johan




[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Photo Sharing]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux