On 08/08/23 3:48 pm, Krzysztof Kozlowski wrote: > On 08/08/2023 11:44, Md Danish Anwar wrote: >>>> properties: >>>> compatible: >>>> @@ -171,6 +181,9 @@ examples: >>>> <0x22400 0x100>; >>>> reg-names = "iram", "control", "debug"; >>>> firmware-name = "am65x-pru0_0-fw"; >>>> + interrupt-parent = <&icssg0_intc>; >>>> + interrupts = <16 2 2>; >>>> + interrupt-names = "vring"; >>>> }; >>> >>> These examples would probably be more helpful if they used the >>> appropriate defines, no? >>> >> >> PRUSS Interrupt controller doesn't have any appropriate defines. This doesn't >> use GIC so defines from arm-gic.h can not be used here. These are specific to >> PRUSS INTC. >> >> I think these example are OK. Please let me know if this is OK to you. > > But isn't "2" type of the interrupt? > > Best regards, > Krzysztof > As per the description of interrupts property in ti,pruss-intc.yaml  Cell 1 is PRU System event number, cell 2 is PRU channel and cell 3 is PRU host_event (target). None of them is type of interrupt. So that's why they all are hardcoded. I don't think we can use IRQ_TYPE macros here.  https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml#:~:text=const%3A%203-,description%3A%20%7C,-Client%20users%20shall -- Thanks and Regards, Danish.