Re: [PATCH 1/4] soc: qcom: aoss: Move length requirements from caller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 7/30/2023 9:10 PM, Bjorn Andersson wrote:
diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
  	/* The message RAM only implements 32-bit accesses */
  	__iowrite32_copy(qmp->msgram + qmp->offset + sizeof(u32),
-			 data, len / sizeof(u32));
-	writel(len, qmp->msgram + qmp->offset);
+			 buf, sizeof(buf) / sizeof(u32));
+	writel(sizeof(buf), qmp->msgram + qmp->offset);

Looks like we are telling the firmware the packet size will always be QMP_MSG_LEN?

This should be ok but might be a problem when debugging. The AOSS firmware only logs size of the message instead of the full string because of memory constraints.

We would normally match the firmware and host logs based on size, but won't be able to differentiate this way with a fixed size.

[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Photo Sharing]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux