Re: [PATCH 2/2] remoteproc: imx_dsp_rproc: add module parameter to ignore ready flag from remote processor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Mathieu,

On 7/17/2023 8:34 PM, Mathieu Poirier wrote:
Hi Iuliana,

On Thu, Jul 13, 2023 at 01:42:51AM +0300, Iuliana Prodan (OSS) wrote:
From: Iuliana Prodan <iuliana.prodan@xxxxxxx>

There are cases when we want to test samples that do not
reply with FW READY message, after fw is loaded and the
remote processor started.
This seems like a bug to me - where is this FW comes from?
The firmware is a generic sample from Zephyr repo:

There is no bug, this is how the application was written.

Rather than modifying a generic sample for i.MX usecase, I prefer doing an "insmod imx_dsp_rproc.ko ignore_dsp_ready=1" just for this sample.


In these cases, do not wait for a confirmation from the remote processor
at start.

Added "ignore_dsp_ready" flag while inserting the module to ignore
remote processor reply after start.
By default, this is off - do not ignore reply from rproc.

Signed-off-by: Iuliana Prodan <iuliana.prodan@xxxxxxx>

This was discovered while testing openamp_rsc_table sample from Zephyr
repo (

We have IPC, but the remote proc doesn't send a FW_READY reply.
  drivers/remoteproc/imx_dsp_rproc.c | 15 +++++++++++++++
  1 file changed, 15 insertions(+)

diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
index b5634507d953..ed89de2f3b98 100644
--- a/drivers/remoteproc/imx_dsp_rproc.c
+++ b/drivers/remoteproc/imx_dsp_rproc.c
@@ -36,7 +36,13 @@ module_param_named(no_mailboxes, no_mailboxes, int, 0644);
  		 "There is no mailbox between cores, so ignore remote proc reply after start, default is 0 (off).");
+static unsigned int imx_dsp_rproc_ignore_ready;
+module_param_named(ignore_dsp_ready, imx_dsp_rproc_ignore_ready, int, 0644);
+		 "Ignore remote proc reply after start, default is 0 (off).");
  #define REMOTE_IS_READY				BIT(0)
/* att flags */
@@ -296,6 +302,12 @@ static int imx_dsp_rproc_ready(struct rproc *rproc)
  	if (!priv->rxdb_ch)
  		return 0;
+ /*
+	 * FW_READY reply is optional/ignored, so don't wait for it.
+	 */
+	if (priv->flags & REMOTE_IGNORE_READY_REPLY)
+		return 0;
  	for (i = 0; i < REMOTE_READY_WAIT_MAX_RETRIES; i++) {
  		if (priv->flags & REMOTE_IS_READY)
  			return 0;
@@ -1119,6 +1131,9 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev)
  		imx_dsp_rproc_mbox_init = imx_dsp_rproc_mbox_alloc;
+ if (imx_dsp_rproc_ignore_ready)
+		priv->flags |= REMOTE_IGNORE_READY_REPLY;
  	dev_set_drvdata(dev, rproc);
INIT_WORK(&priv->rproc_work, imx_dsp_rproc_vq_work);

[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Photo Sharing]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux