On 6/12/23 16:17, Arnd Bergmann wrote:
> On Mon, Jun 12, 2023, at 16:10, Arnaud POULIQUEN wrote:
>
>>> ddata->rsc_va = devm_ioremap_wc(dev, rsc_pa, RSC_TBL_SIZE);
>>> if (IS_ERR_OR_NULL(ddata->rsc_va)) {
>>> - dev_err(dev, "Unable to map memory region: %pa+%zx\n",
>>> + dev_err(dev, "Unable to map memory region: %pa+%x\n",
>>> &rsc_pa, RSC_TBL_SIZE);
>>
>> What about cast the RSC_TBL_SIZE define instead to ensure to be independent from
>> the arch and to match with the use of RSC_TBL_SIZE?
>>
>> #define RSC_TBL_SIZE ((size_t)1024)
>
> I have no objection to that, but I don't see it doing anything good either,
> as this is a constant value that will always work.
>
> Arnd
It was just to avoid to have the constant used with different types in the code
But that's nitpicking, let's keep your proposal.
Thanks,
Arnaud
