Hello Dan,
On 5/22/23 09:46, Dan Carpenter wrote:
> There is a cut and paste bug so this code was returning the wrong
> variable. It should have been "ddata->hold_boot_rst" instead of
> "ddata->rst".
>
> Fixes: de598695a2ad ("remoteproc: stm32: Allow hold boot management by the SCMI reset controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/remoteproc/stm32_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 0e322697d210..a7457777aae4 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -755,7 +755,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
>
> ddata->hold_boot_rst = devm_reset_control_get_optional(dev, "hold_boot");
> if (IS_ERR(ddata->hold_boot_rst))
> - return dev_err_probe(dev, PTR_ERR(ddata->rst),
> + return dev_err_probe(dev, PTR_ERR(ddata->hold_boot_rst),
> "failed to get hold_boot reset\n");
Good catch!
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@xxxxxxxxxxx>
Thanks,
Arnaud
>
> if (!ddata->hold_boot_rst && IS_ENABLED(CONFIG_HAVE_ARM_SMCCC)) {
