On 7.05.2023 16:48, Krzysztof Kozlowski wrote:
> adsp_segment_dump() is not used outside of this unit, so add missing
> static to fix:
>
> drivers/remoteproc/qcom_q6v5_pas.c:108:6: warning: no previous prototype for ‘adsp_segment_dump’ [-Wmissing-prototypes]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
(should we add a fixes tag for this one? I'm unsure but wouldn't mind
either way)
Konrad
> drivers/remoteproc/qcom_q6v5_pas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index e34d82b18a67..f77d11c91a75 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -105,7 +105,7 @@ struct qcom_adsp {
> struct qcom_scm_pas_metadata dtb_pas_metadata;
> };
>
> -void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
> +static void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
> void *dest, size_t offset, size_t size)
> {
> struct qcom_adsp *adsp = rproc->priv;
